Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rangefeed: deflake TestBudgetReleaseOnProcessorStop #109809

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

pav-kv
Copy link
Collaborator

@pav-kv pav-kv commented Aug 31, 2023

Fixes #109802
Epic: none
Release note: none

@pav-kv pav-kv requested review from aliher1911 and a team August 31, 2023 14:28
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@pav-kv
Copy link
Collaborator Author

pav-kv commented Aug 31, 2023

Before the fix the test flaked pretty eagerly under --stress. After the fix 10,000 runs succeeded.

@pav-kv pav-kv requested a review from erikgrinaker August 31, 2023 22:18
@pav-kv
Copy link
Collaborator Author

pav-kv commented Sep 1, 2023

bors r=erikgrinaker

@craig
Copy link
Contributor

craig bot commented Sep 1, 2023

This PR was included in a batch that timed out, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Sep 1, 2023

Build succeeded:

@craig craig bot merged commit 282573b into cockroachdb:master Sep 1, 2023
@pav-kv pav-kv deleted the deflake-rangefeed-test branch September 1, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kv/kvserver/rangefeed: TestBudgetReleaseOnProcessorStop failed
3 participants